lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Aug 2017 22:03:43 -0700 (PDT) From: David Miller <davem@...emloft.net> To: stephen@...workplumber.org Cc: aviad.krawczyk@...wei.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, bc.y@...wei.com, victor.gissin@...wei.com, zhaochen6@...wei.com, tony.qu@...wei.com Subject: Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface From: Stephen Hemminger <stephen@...workplumber.org> Date: Thu, 17 Aug 2017 17:42:05 -0700 > Please drop these functions, they do nothing and are not used > as stubs in any operations table. It might have been helpful to scan the entire series to understand why it looks this way. He's building the driver up, one piece at a time, filling in the full implementation as is possible as more and more infrastructure is added. So some functions start empty when a method is needed to be filled in, and then gradually obtains more and more content throughout the series. And this is a fine way to add a huge new driver (although not my personal preference).
Powered by blists - more mailing lists