linux-kernel - Re: [PATCH] staging:wlan-ng Fix Multiple line dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 Aug 2017 11:10:53 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Janani S <jananis37@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        adrien.descamps@...il.com, sergio.paracuellos@...il.com,
        davem@...emloft.net
Subject: Re: [PATCH] staging:wlan-ng Fix Multiple line dereference

On Fri, Aug 18, 2017 at 06:16:39PM +0530, Janani S wrote:
> This patch fixes multiple line dereference warning reported
> by checkpatch script.
> 
> Signed-off-by: Janani S <jananis37@...il.com>
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index ee5fa86..2746e13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
>  		kfree(ctlx);
>  	} else if (mode == DOWAIT) {
>  		struct usbctlx_cmd_completor completor;
> +		struct usbctlx_completor *cmplt;
>  
> -		result =
> -		    hfa384x_usbctlx_complete_sync(hw, ctlx,
> -						  init_cmd_completor(&completor,
> -								     &ctlx->
> -								     inbuf.
> -								     cmdresp,
> -								     &cmd->
> -								     result));
> +		cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> +					   &cmd->result);
> +		result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
>  	}
>  
>  done:

Someone else sent this same patch right before you did, sorry.

greg k-h