linux-kernel - Re: [PATCH] binder: let ANDROID_BINDER_IPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Aug 2017 22:35:36 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jisheng Zhang <jszhang@...vell.com>
Cc:     devel@...verdev.osuosl.org, riandrews@...roid.com,
        linux-kernel@...r.kernel.org, arve@...roid.com,
        john.stultz@...aro.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on
 32bit ARM

On Wed, Aug 23, 2017 at 10:34:20AM +0800, Jisheng Zhang wrote:
> On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote:
> 
> > On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote:
> > > As noted in commit d0bdff0db809 ("staging: Fix build issues with new
> > > binder API"), we can add back the choice for 32bit ARM "once a 64bit
> > > __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM:
> > > 8091/2: add get_user() support for 8 byte types") has added the
> > > support, so it's time to let ANDROID_BINDER_IPC_32BIT be selectable on
> > > 32bit ARM  
> > 
> > Ok, but:
> > 
> > > 
> > > Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> > > ---
> > >  drivers/android/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> > > index 832e885349b1..aca5dc30b97b 100644
> > > --- a/drivers/android/Kconfig
> > > +++ b/drivers/android/Kconfig
> > > @@ -32,7 +32,7 @@ config ANDROID_BINDER_DEVICES
> > >  	  therefore logically separated from the other devices.
> > >  
> > >  config ANDROID_BINDER_IPC_32BIT
> > > -	bool
> > > +	bool "Use old (Android 4.4 and earlier) 32-bit binder API"
> > >  	depends on !64BIT && ANDROID_BINDER_IPC  
> > 
> > You don't actually change the depends line :(
> > 
> > Please fix up, and test it, and then resend.
> 
> IHOM, the dependency is correct: 64bit platforms don't support
> ANDROID_BINDER_IPC_32BIT. What do you think?

I think your changelog text is totally wrong, please fix this up
properly and resend it if you think it is needed.

thanks,

greg k-h