linux-kernel - Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2017 23:17:02 +0930
From:   Andrew Jeffery <andrew@...id.au>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Yong Li <sdliyong@...il.com>, Joel Stanley <joel@....id.au>,
        Arnd Bergmann <arnd@...db.de>,
        Rick Altherr <raltherr@...gle.com>,
        Rob Herring <robh@...nel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write
 logic

On Wed, 2017-08-23 at 10:23 +0200, Linus Walleij wrote:
> > On Wed, Aug 23, 2017 at 1:54 AM, Andrew Jeffery <andrew@...id.au> wrote:
> > On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote:
> > > > > > > > On Tue, Aug 15, 2017 at 6:21 PM, Yong Li <sdliyong@...il.com> wrote:
> > > > On AST2500, the hardware strap register(SCU70) only accepts write ‘1’,
> > > > to clear it to ‘0’, must set bits(write  ‘1’) to SCU7C
> > > > 
> > > > Signed-off-by: Yong Li <sdliyong@...il.com>
> > > 
> > > Patch applied with Andrew's review/test tags.
> > 
> > I realised after I sent the tags on v3 that I'd made a mistake: There's a
> > slightly awkward to test bug in the v3 implementation. I followed up on v3 with
> > this:
> > 
> >         https://lkml.org/lkml/2017/8/16/905
> > 
> > And Yong sent out a corresponding v4:
> > 
> >         https://patchwork.ozlabs.org/patch/802946/
> 
> Ah. I got confused and picked the wrong version.

Entirely my fault. Apologies again for the confusion. I owe you a few drinks if
we ever meet :)

> 
> > I see you've pushed Yong's v3 in pinctrl/devel - can we revert/remove that and
> > apply v4?
> 
> No I would have to revert the patch.
> 
> Can't we simply make a small fixup patch?

I couldn't recall what the rebase policy was for pinctrl/devel.

I have sent the fixup patch:

	http://patchwork.ozlabs.org/patch/804981/

Cheers,

Andrew

> 
> Yours,
> Linus Walleij
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)