linux-kernel - Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2017 16:14:01 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Andi Kleen <andi@...stfloor.org>, peterz@...radead.org,
        acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Joe Mario <jmario@...hat.com>
Subject: Re: [PATCH v5 3/4] perf, tools: Add support for printing new
 mem_info encodings

On Wed, Aug 23, 2017 at 07:00:32AM -0700, Andi Kleen wrote:
> > Andi,
> > how is this 'Remote' different from the remote levels in mem_lvl?
> > 
> >         "Remote RAM (1 hop)",
> >         "Remote RAM (2 hops)",
> >         "Remote Cache (1 hop)",
> >         "Remote Cache (2 hops)",
> 
> It applies to any other level. This is needed to express
> "Remote unknown level", as is reported by Skylake.

so if I find HITM with this flag set I should count it
as remote HITM then? something like attached.. untested

thanks,
jirka

---
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 06f5a3a4295c..65e22b9e59f9 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -279,6 +279,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi)
 	u64 lvl    = data_src->mem_lvl;
 	u64 snoop  = data_src->mem_snoop;
 	u64 lock   = data_src->mem_lock;
+	bool mr    = data_src->mem_remote;
 	int err = 0;
 
 #define HITM_INC(__f)		\
@@ -324,7 +325,7 @@ do {				\
 			}
 
 			if ((lvl & P(LVL, REM_RAM1)) ||
-			    (lvl & P(LVL, REM_RAM2))) {
+			    (lvl & P(LVL, REM_RAM2)) || mr) {
 				stats->rmt_dram++;
 				if (snoop & P(SNOOP, HIT))
 					stats->ld_shared++;
@@ -334,7 +335,7 @@ do {				\
 		}
 
 		if ((lvl & P(LVL, REM_CCE1)) ||
-		    (lvl & P(LVL, REM_CCE2))) {
+		    (lvl & P(LVL, REM_CCE2)) || mr) {
 			if (snoop & P(SNOOP, HIT))
 				stats->rmt_hit++;
 			else if (snoop & P(SNOOP, HITM))