linux-kernel - [PATCH] fbcon: remove restriction on margin color

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2017 14:18:53 -0500
From:   David Lechner <david@...hnology.com>
To:     linux-fbdev@...r.kernel.org
Cc:     David Lechner <david@...hnology.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] fbcon: remove restriction on margin color

This removes the restriction on the value range of the fbcon=margin:
parameter. The color value really depends on the driver being used.

Signed-off-by: David Lechner <david@...hnology.com>
---

This is a follow up to "fbcon: add fbcon=margin:<color> command line option".

https://lkml.org/lkml/2017/8/23/479

 Documentation/fb/fbcon.txt    | 2 +-
 drivers/video/console/fbcon.c | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/fb/fbcon.txt b/Documentation/fb/fbcon.txt
index 1822b19..a38d3aa 100644
--- a/Documentation/fb/fbcon.txt
+++ b/Documentation/fb/fbcon.txt
@@ -153,7 +153,7 @@ C. Boot options
 	This option specifies the color of the margins. The margins are the
 	leftover area at the right and the bottom of the screen that are not
 	used by text. By default, this area will be black. The 'color' value
-	is 0 to 7 where 0 is black and 7 is white.
+	is an integer number that depends on the framebuffer driver being used.
 
 C. Attaching, Detaching and Unloading
 
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 1bce7a7..82e5d6b 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -497,8 +497,6 @@ static int __init fb_console_setup(char *this_opt)
 			options += 7;
 			if (*options)
 				margin_color = simple_strtoul(options, &options, 0);
-			if (margin_color > 7)
-				margin_color = 0;
 			continue;
 		}
 	}
-- 
2.7.4