linux-kernel - Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Aug 2017 19:33:45 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg KH <gregkh@...uxfoundation.org>, laurentiu.tudor@....com
Cc:     stuyoder@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, agraf@...e.de, ioana.ciornei@....com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp()
 returns

On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@....com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@....com>
> > 
> > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > this place, so fix it.
> 
> You will just get someone else fixing it as it is not what checkpatch
> recommends, so just leave it as-is please.

No.  That's not correct.

checkpatch does not make a recommendation about
style use with the strcmp family of functions.