linux-kernel - Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2017 22:15:41 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Chunyu Hu <chuhu@...hat.com>
Cc:     mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter

On Wed, 23 Aug 2017 18:58:03 -0400 (EDT)
Chunyu Hu <chuhu@...hat.com> wrote:

> ----- Original Message -----
> > From: "Steven Rostedt" <rostedt@...dmis.org>
> > To: "Chunyu Hu" <chuhu@...hat.com>
> > Cc: mingo@...nel.org, linux-kernel@...r.kernel.org
> > Sent: Wednesday, August 23, 2017 12:52:49 PM
> > Subject: Re: [PATCH 2/2] tracing: Fix kmemleak in set_trigger_filter
> > 
> > On Wed, 23 Aug 2017 10:41:55 -0400
> > Steven Rostedt <rostedt@...dmis.org> wrote:
> >   
> > >  * On success, returns 0 and *@...terp points to the new filter.  On
> > >  * failure, returns -errno and *@...terp may point to %NULL or to a new
> > >  * filter.  In the latter case, the returned filter contains error
> > >  * information if @set_str is %true and the caller is responsible for
> > >  * freeing it.
> > > 
> > > So filter contains an error string when it fails. It seems that we
> > > should somehow propagate that up the chain to display. I'll look more
> > > into this.  
> > 
> > The bug is in create_filter(), because "set_str" is set to false, and
> > the filter should not be passed back allocated on error.  
> 
> Thanks for all the analysis. I think you are right. I'll try to have a test on it
> in case we miss something. But please don't block on my test.
> 

My tests are almost done, but I wont send anything till tomorrow. I can
wait a day to post. There's a few other changes I need to send to Linus
as well.

-- Steve