linux-kernel - Re: [PATCH v10 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Aug 2017 09:55:14 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Byungchul Park <byungchul.park@....com>
Cc:     peterz@...radead.org, mingo@...nel.org, joel.opensrc@...il.com,
        linux-kernel@...r.kernel.org, juri.lelli@...il.com,
        kernel-team@....com
Subject: Re: [PATCH v10 2/2] sched/rt: Add support for SD_PREFER_SIBLING on
 find_lowest_rq()

On Thu, 24 Aug 2017 10:06:03 +0900
Byungchul Park <byungchul.park@....com> wrote:

> Hello Steven,
> 
> Can I keep your reviewed-by with comments modified?

Yes, but I have one nit.


> @@ -1668,9 +1691,35 @@ static int find_lowest_rq(struct task_struct *task)
>  				return this_cpu;
>  			}
>  
> -			best_cpu = cpumask_first_and(lowest_mask,
> -						     sched_domain_span(sd));
> +			/*
> +			 * If a cpu being in lowest_mask & current sd &
> +			 * ~prefer sd is valid, that becomes our choice.

I can't parse the above sentence.

-- Steve

> +			 * Of course, the lowest possible cpu is already
> +			 * under consideration through lowest_mask.
> +			 */
> +			best_cpu = find_cpu(lowest_mask, sd, prefer);
> +