linux-kernel - Re: [PATCH] KVM: arm/arm64: vgic: constify seq_operations and file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Aug 2017 09:20:34 -0700
From:   Christoffer Dall <christoffer.dall@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     marc.zyngier@....com, pbonzini@...hat.com, rkrcmar@...hat.com,
        linux-kernel@...r.kernel.org, kvmarm@...ts.cs.columbia.edu,
        kvm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] KVM: arm/arm64: vgic: constify seq_operations and
 file_operations

On Wed, Aug 23, 2017 at 12:25:36PM +0530, Arvind Yadav wrote:
> vgic_debug_seq_ops and file_operations are not supposed to change
> at runtime and none of the structures is modified.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied, thanks.
-Christoffer

> ---
>  virt/kvm/arm/vgic/vgic-debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/virt/kvm/arm/vgic/vgic-debug.c b/virt/kvm/arm/vgic/vgic-debug.c
> index 7072ab7..10b3817 100644
> --- a/virt/kvm/arm/vgic/vgic-debug.c
> +++ b/virt/kvm/arm/vgic/vgic-debug.c
> @@ -234,7 +234,7 @@ static int vgic_debug_show(struct seq_file *s, void *v)
>  	return 0;
>  }
>  
> -static struct seq_operations vgic_debug_seq_ops = {
> +static const struct seq_operations vgic_debug_seq_ops = {
>  	.start = vgic_debug_start,
>  	.next  = vgic_debug_next,
>  	.stop  = vgic_debug_stop,
> @@ -255,7 +255,7 @@ static int debug_open(struct inode *inode, struct file *file)
>  	return ret;
>  };
>  
> -static struct file_operations vgic_debug_fops = {
> +static const struct file_operations vgic_debug_fops = {
>  	.owner   = THIS_MODULE,
>  	.open    = debug_open,
>  	.read    = seq_read,
> -- 
> 1.9.1
>