linux-kernel - Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2017 10:41:23 +0300
From:   Dmitry Fleytman <dmitry@...nix.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sandeep Singh <sandeep.singh@....com>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Devin Heitmueller <dheitmueller@...nellabs.com>,
        Lukáš Lalinský <lukas@...gene.sk>,
        USB list <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C


> On 24 Aug 2017, at 10:58 AM, Kai-Heng Feng <kai.heng.feng@...onical.com> wrote:
> 
> On Mon, Aug 21, 2017 at 6:03 PM, Dmitry Fleytman <dmitry@...nix.com> wrote:
>> Commit e0429362ab15
>> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
>> introduced quirk to workaround an issue with some Logitech webcams.
>> 
>> Apparently model C920-C has the same issue so applying
>> the same quirk as well.
> 
> I think it's better to also mention "C920-C" in the comment section.


I agree. See v2 (just sent).

Thanks,
Dmitry


> 
>> 
>> See aforementioned commit message for detailed explanation of the problem.
>> 
>> Signed-off-by: Dmitry Fleytman <dmitry@...nix.com>
>> ---
>> drivers/usb/core/quirks.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 574da2b..36d4841 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
>> 
>>        /* Logitech HD Pro Webcams C920 and C930e */
>>        { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
>> +       { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
>>        { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
>> 
>>        /* Logitech ConferenceCam CC3000e */
>> --
>> 2.7.4
>>