linux-kernel - Re: [PATCH 11/11] staging: typec: tcpm: Switch to PORT_RESET instead of SNK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 27 Aug 2017 10:27:52 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] staging: typec: tcpm: Switch to PORT_RESET instead
 of SNK_UNATTACHED

On Sat, Aug 26, 2017 at 11:52:33PM -0700, Badhri Jagan Sridharan wrote:
> When VBUS is not discovered within PD_T_PS_SOURCE_ON although Rp
> is detected on CC, TCPM switches the port to SNK_UNATTACHED
> state. SNK_UNATTACHED, however does not force TYPEC_CC_OPEN which
> makes the partner(source) to think that it is connected.
> 
> To overcome this issue, force the port into PORT_RESET state
> to make sure the CC lines are open.
> 
> Signed-off-by: Badhri Jagan Sridharan <Badhri@...gle.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/staging/typec/tcpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
> index 9e0111dea7c4..47b8fec5ea36 100644
> --- a/drivers/staging/typec/tcpm.c
> +++ b/drivers/staging/typec/tcpm.c
> @@ -2380,7 +2380,7 @@ static void run_state_machine(struct tcpm_port *port)
>  				       0);
>  		else
>  			/* Wait for VBUS, but not forever */
> -			tcpm_set_state(port, SNK_UNATTACHED, PD_T_PS_SOURCE_ON);
> +			tcpm_set_state(port, PORT_RESET, PD_T_PS_SOURCE_ON);
>  		break;
>  
>  	case SRC_TRY:
> -- 
> 2.14.1.342.g6490525c54-goog
>