linux-kernel - Re: [PATCH] perf symbols: Fix plt entry calculation for ARM and AARCH64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Aug 2017 11:49:55 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Li Bin <huawei.libin@...wei.com>
Cc:     Namhyung Kim <namhyung@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Hemant Kumar <hemant@...ux.vnet.ibm.com>,
        alexis.berlemont@...il.com, dtolnay@...il.com,
        Milian Wolff <milian.wolff@...b.com>,
        Wang Nan <wangnan0@...wei.com>, guohanjun@...wei.com,
        zhangmengting@...wei.com
Subject: Re: [PATCH] perf symbols: Fix plt entry calculation for ARM and
 AARCH64

Em Tue, Jun 06, 2017 at 10:47:26AM +0900, Namhyung Kim escreveu:
> On Mon, Jun 5, 2017 at 9:34 AM, Li Bin <huawei.libin@...wei.com> wrote:
> > On x86, the plt header size is as same as the plt entry size, and
> > can be identified from shdr's sh_entsize of the plt.
> > But we cann't assume that the sh_entsize of the plt shdr is always
> > the plt entry size in all architecture, and the plt header size may
> > be not as same as the plt entry size in some architecure.
> >
> > On ARM, the plt header size is 20 bytes and the plt entry size is 12
> > bytes(don't consider the FOUR_WORD_PLT case)
> > that refer to the binutils implementation.
<SNIP>
> > NOTES:
> > In addition to ARM and AARCH64, other architectures, such as
> > s390/alpha/mips/parisc/poperpc/sh/sparc/xtensa also need to consider
> > this issue.
> >
> > Signed-off-by: Li Bin <huawei.libin@...wei.com>
> 
> I don't know other archs, but this change looks ok to me..
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks, and sorry for the delay in processing this one.

- Arnaldo