lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Aug 2017 19:24:07 -0700 From: Stefan Agner <stefan@...er.ch> To: Kees Cook <keescook@...omium.org>, Nick Desaulniers <ndesaulniers@...gle.com> Cc: Jessica Yu <jeyu@...nel.org>, Matthias Kaehlcke <mka@...omium.org>, Rusty Russell <rusty@...tcorp.com.au>, LKML <linux-kernel@...r.kernel.org>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Michal Marek <mmarek@...e.com>, Arnd Bergmann <arnd@...db.de>, Doug Anderson <dianders@...omium.org>, Grant Grundler <grundler@...omium.org>, Greg Hackmann <ghackmann@...gle.com>, Michael Davidson <md@...gle.com>, Alexander Potapenko <glider@...gle.com>, Bernhard.Rosenkranzer@...aro.org, keescook@...gle.com Subject: Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE On 2017-08-28 10:41, Kees Cook wrote: > On Mon, Aug 28, 2017 at 10:38 AM, Nick Desaulniers > <ndesaulniers@...gle.com> wrote: >> I think Kees' proposal is a better solution; rather than require all >> usage of device table to remember to add const, have the macro add it >> for all users. Otherwise if you require caller's to add it, they may >> forget. > > And with the coccinelle script, it should be easy to invert the logic > and remove const from the callers... > I tried to reproduce my findings again but was not successful :-( I must have changed .config or something in between and draw wrong conclusions... So removing the const in the module.h alias actually did not change anything... It did not help for drivers which forget to constify... I think even the alias in module.h was actually illegal according to C standard: (C89, 6.2.7p2) "All declarations that refer to the same object or function shall have compatible type; otherwise the behavior is undefined." I guess it would still make sense to constify the structs for most of the 620 drivers which do not have it const currently. I found some driver actually change the table at runtime, e.g. drivers/net/usb/pegasus.c, so we would have to exclude them. -- Stefan
Powered by blists - more mailing lists