linux-kernel - Re: [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Aug 2017 12:55:47 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jonathan Whitaker <jon.b.whitaker@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        sayli karnik <karniksayli1995@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: ks7010: Fix coding style and remove
 checkpatch.pl warnings.

On Tue, Aug 29, 2017 at 08:57:34PM -0600, Jonathan Whitaker wrote:
> It is prefered to use '"%s...", __func__ instead of function names for
> logging. This commit replaces hardcoded function name strings to the
> more preferred '"%s...", __func__' style. These warnings were reported
> by checkpatch.pl.
> 
> Signed-off-by: Jonathan Whitaker <jon.b.whitaker@...il.com>
> 
> Changes in v2:
>   - Wrapped the changelog text to 72 columns.
>   - Fixed the commit subject to be more clear.
> ---

Put the Changelog under the --- cut off line.

>  drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 9b28ee1..c0e91c3 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>  	unsigned char byte;
>  	int ret;
>  
> -	DPRINTK(5, "ks7010_sdio_probe()\n");
> +	DPRINTK(5, "%s()\n", __func__);

Just delete both the printks.  You can get the same information with
ftrace.

regards,
dan carpenter