linux-kernel - Re: [PATCH] NTB: make idt_89hpes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 31 Aug 2017 13:55:56 -0400
From:   Jon Mason <jdmason@...zu.us>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, fancer.lancer@...il.com,
        dave.jiang@...el.com, Allen.Hubbe@....com,
        linux-ntb@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NTB: make idt_89hpes_cfg const

On Fri, Aug 11, 2017 at 11:17:43PM +0530, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
> Done using Coccinelle.

Pulled into my ntb-next branch

Thanks,
Jon

> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  drivers/ntb/hw/idt/ntb_hw_idt.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index d44d7ef..0cd79f3 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -2628,35 +2628,35 @@ static void idt_pci_remove(struct pci_dev *pdev)
>  /*
>   * IDT PCIe-switch models ports configuration structures
>   */
> -static struct idt_89hpes_cfg idt_89hpes24nt6ag2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes24nt6ag2_config = {
>  	.name = "89HPES24NT6AG2",
>  	.port_cnt = 6, .ports = {0, 2, 4, 6, 8, 12}
>  };
> -static struct idt_89hpes_cfg idt_89hpes32nt8ag2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt8ag2_config = {
>  	.name = "89HPES32NT8AG2",
>  	.port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
>  };
> -static struct idt_89hpes_cfg idt_89hpes32nt8bg2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt8bg2_config = {
>  	.name = "89HPES32NT8BG2",
>  	.port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
>  };
> -static struct idt_89hpes_cfg idt_89hpes12nt12g2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes12nt12g2_config = {
>  	.name = "89HPES12NT12G2",
>  	.port_cnt = 3, .ports = {0, 8, 16}
>  };
> -static struct idt_89hpes_cfg idt_89hpes16nt16g2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes16nt16g2_config = {
>  	.name = "89HPES16NT16G2",
>  	.port_cnt = 4, .ports = {0, 8, 12, 16}
>  };
> -static struct idt_89hpes_cfg idt_89hpes24nt24g2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes24nt24g2_config = {
>  	.name = "89HPES24NT24G2",
>  	.port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
>  };
> -static struct idt_89hpes_cfg idt_89hpes32nt24ag2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt24ag2_config = {
>  	.name = "89HPES32NT24AG2",
>  	.port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
>  };
> -static struct idt_89hpes_cfg idt_89hpes32nt24bg2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt24bg2_config = {
>  	.name = "89HPES32NT24BG2",
>  	.port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
>  };
> -- 
> 1.9.1
>