linux-kernel - Re: Support for BQ28Z610 Battery Monitor IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 5 Sep 2017 09:03:26 +0200
From:   Rodolfo Giometti <giometti@...eenne.com>
To:     rajender.reddy@...salit.in
Cc:     afd@...com, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        security@...nel.org, linux-api@...r.kernel.org, trivial@...nel.org
Subject: Re: Support for BQ28Z610 Battery Monitor IC

On 04/09/2017 15:53, rajender.reddy@...salit.in wrote:
> Dear Rodolfo Giometti,
> 
> As discussed please find attached patch.
> Please let me know if you need more details.

It looks OK to me... however:

- rewrite the patch's title as "power bq27xxx_battery: add support for BQ28Z610 
battery monitor IC"

- align the "=" characters as follow:

+	[BQ28Z610] = {
+		[BQ27XXX_REG_CTRL]     = 0x00,
+		[BQ27XXX_REG_TEMP]     = 0x06,
+		[BQ27XXX_REG_INT_TEMP] = INVALID_REG_ADDR,
+		[BQ27XXX_REG_VOLT]     = 0x08,
...

Then send the patch to the mail list or maintainers ad described into the 
MAINTAINERS file and adding me in Cc.

Good job! :-)

Ciao,

Rodolfo

-- 

HCE Engineering                      e-mail: giometti@...-engineering.it
GNU/Linux Solutions                          giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it