linux-kernel - Re: [PATCH] IRQ, cpu-hotplug: Fix a race between CPU hotplug and IRQ desc alloc/free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Sep 2017 09:15:40 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Huang, Ying" <ying.huang@...el.com>
cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IRQ, cpu-hotplug: Fix a race between CPU hotplug and
 IRQ desc alloc/free

On Tue, 5 Sep 2017, Huang, Ying wrote:
> Thomas Gleixner <tglx@...utronix.de> writes:
> > +	/* Interrupts are moved away from the dying cpu, reenable alloc/free */
> > +	irq_unlock_sparse();
> > +
> 
> I don't understand this.  It appears that irq_migrate_all_off_this_cpu()
> is called in take_cpu_down() which has sparse_irq_lock held already.

You're right. I was looking at the wrong place.

Thanks,

	tglx