linux-kernel - Re: [PATCH] staging:rtl8188eu Fix msleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Sep 2017 16:14:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Janani Sankara Babu <jananis37@...il.com>
Cc:     devel@...verdev.osuosl.org, goudapatilk@...il.com,
        insafonov@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

On Tue, Sep 05, 2017 at 03:36:41PM +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms 
> 
> Signed-off-by: Janani Sankara Babu <jananis37@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index f86c9ce..78edc15 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
>  			DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
>  			break;
>  		}
> -		msleep(1);
> +		usleep_range(0, 1000);

How do you know this is a valid range to sleep for?