linux-kernel - Re: [bisected] Re: Module removal-related regression?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Sep 2017 12:55:51 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jakub Kicinski <kubakici@...pl>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [bisected] Re: Module removal-related regression?

On Sat, Sep 9, 2017 at 12:27 PM, Jakub Kicinski <kubakici@...pl> wrote:
> On Sat, 9 Sep 2017 19:41:21 +0200, Jakub Kicinski wrote:
>> Hi!
>>
>> I'm having trouble with modules on linux/master.  rmmod succeeds but the
>> module is still loaded and the refcount goes to 1:
>>
>> #rmmod nfp; insmod ./src/nfp.ko nfp_pf_netdev=0 ; \
>>       /opt/netronome/bin/nfp-hwinfo -n 2  assembly.partno \
>>       lsmod | grep nfp; \
>>       rmmod nfp; \
>>       lsmod | grep nfp
>> nfp                   249856  0
>> nfp                   200704  1
>>
>> If I rmmod again the module will be actually unloaded.  The user space
>> is mostly Ubuntu 14.04.  Has anyone seen this?  I'm trying to bisect
>> now...
>
> Got 'em!
>
> commit 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 (HEAD, refs/bisect/bad)
> Author: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Date:   Wed Jul 19 17:24:30 2017 -0700
>
>     driver core: emit uevents when device is bound to a driver

Does it happen with all modules or only nfp one?

It seems to work here:

dtor@...r-glaptop3:~ $ lsmod | grep psmouse
psmouse               135168  0
dtor@...r-glaptop3:~ $ sudo rmmod psmouse
dtor@...r-glaptop3:~ $ lsmod | grep psmouse
dtor@...r-glaptop3:~ $ sudo modprobe psmouse

Thanks.

-- 
Dmitry