[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 9 Sep 2017 20:45:10 +0800
From: Wig C <onlywig@...il.com>
To: fabio.estevam@....com
Cc: robh+dt@...nel.org, mark.rutland@....com, linux@...linux.org.uk,
shawnguo@...nel.org, kernel@...gutronix.de,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support.
On Sat, Sep 9, 2017 at 6:28 AM, Wig C <onlywig@...il.com> wrote:
> +&usdhc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc2>;
> + bus-width = <4>;
> + vmmc-supply = <&wlan_en_reg>;
> + no-1-8-v;
> + keep-power-in-suspend;
> + non-removable;
> + cap-power-off-card;
As I mentioned previously the indentation is not correct here.
You should use tab instead of spaces.
checkpatch also complains about it:
WARNING: please, no spaces at the start of a line
#699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654:
+ non-removable;$
WARNING: please, no spaces at the start of a line
#700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655:
+ cap-power-off-card;$
Hello Fabio:
I will fix this on next patch, sorry I miss it.
> +&wdog1 {
> + status = "okay";
> +};
Why don't you use like this as you intended in the original patch?
&wdog1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wdog>;
fsl,ext-reset-output;
status = "okay";
};
My original patch has never support hardware watch dog as following link:
https://www.spinics.net/lists/kernel/msg2594724.html
I used soft reset on Pistachio, sorry for cause your misunderstand, and
thanks for your kindly correction.
Wig
Powered by blists - more mailing lists