linux-kernel - Re: [PATCH] test_bitmap: Use ULL suffix for 64-bit constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 Sep 2017 16:33:19 +0300
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] test_bitmap: Use ULL suffix for 64-bit constants

On Sun, Sep 10, 2017 at 12:48:43PM +0200, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
> 
>     lib/test_bitmap.c:189: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:190: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:194: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:195: warning: integer constant is too large for ‘long’ type
> 
> Add the missing "ULL" suffix to fix this.
> 
> Fixes: 60ef690018b262dd ("bitmap: introduce BITMAP_FROM_U64()")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks.
Acked-by: Yury Norov <ynorov@...iumnetworks.com>

> ---
>  lib/test_bitmap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 599c6713f2a2aaa8..aa1f2669bdd5d836 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -186,13 +186,13 @@ static const unsigned long exp[] __initconst = {
>  	BITMAP_FROM_U64(0x22222222),
>  	BITMAP_FROM_U64(0xffffffff),
>  	BITMAP_FROM_U64(0xfffffffe),
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const unsigned long exp2[] __initconst = {
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> -- 
> 2.7.4