linux-kernel - Re: [PATCH] Staging: atomisp: fix alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Sep 2017 17:59:14 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Branislav Radocaj <branislav@...ocaj.org>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        alan@...yncelyn.cymru, hans.verkuil@...co.com,
        rvarsha016@...il.com, singhalsimran0@...il.com,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: atomisp: fix alloc_cast.cocci warnings

Hi Branislav,

On Thu, Sep 07, 2017 at 06:26:42PM +0200, Branislav Radocaj wrote:
> Remove casting the values returned by memory allocation functions
> like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.
> 
> Semantic patch information:
> This makes an effort to find cases of casting of values returned by
> kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc,
> kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes
> the casting as it is not required. The result in the patch case may
> need some reformatting.
> 
> Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci
> 
> Signed-off-by: Branislav Radocaj <branislav@...ocaj.org>
> ---
>  drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> index eecd8cf71951..56765d6a0498 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> @@ -133,7 +133,7 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
>  		char *namebuffer;
>  		int namelength = (int)strlen(name);
>  
> -		namebuffer = (char *) kmalloc(namelength + 1, GFP_KERNEL);
> +		namebuffer = kmalloc(namelength + 1, GFP_KERNEL);

This chunk no longer applies, I'm applying the one that does. The kmalloc
has been replaced by kstrdup.

>  		if (namebuffer == NULL)
>  			return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
>  
> @@ -149,7 +149,7 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
>  		size_t configstruct_size = sizeof(struct ia_css_config_memory_offsets);
>  		size_t statestruct_size = sizeof(struct ia_css_state_memory_offsets);
>  
> -		char *parambuf = (char *)kmalloc(paramstruct_size + configstruct_size + statestruct_size,
> +		char *parambuf = kmalloc(paramstruct_size + configstruct_size + statestruct_size,
>  							GFP_KERNEL);
>  		if (parambuf == NULL)
>  			return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi