linux-kernel - RE: [PATCH RFC V2 00/10] perf top optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2017 15:29:44 +0000
From:   "Liang, Kan" <kan.liang@...el.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jolsa@...nel.org" <jolsa@...nel.org>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        "Odzioba, Lukasz" <lukasz.odzioba@...el.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>
Subject: RE: [PATCH RFC V2 00/10] perf top optimization

> 
> Em Sun, Sep 10, 2017 at 07:23:13PM -0700, kan.liang@...el.com escreveu:
> 
> So I got the first two patches already merged, and made some comments
> about the other patches, please check those,
> 

Thanks for the review Arnaldo.

I will take a close look for the comments. 
For the next version, I only need to include patch 3-10, correct?


Thanks,
Kan

> Thanks,
> 
> - Arnaldo
> 
> > Changes since V1:
> >  - Patch 1: machine threads and hashtable related renaming (Arnaldo)
> >  - Patch 6: use a smaller locked section for comm_str__put
> >    add a locked wrapper for comm_str__findnew              (Arnaldo)
> >
> > Kan Liang (10):
> >   perf tools: hashtable for machine threads
> >   perf tools: using scandir to replace readdir
> >   petf tools: using comm_str to replace comm in hist_entry
> >   petf tools: introduce a new function to set namespaces id
> >   perf tools: lock to protect thread list
> >   perf tools: lock to protect comm_str rb tree
> >   perf tools: change machine comm_exec type to atomic
> >   perf top: implement multithreading for perf_event__synthesize_threads
> >   perf top: add option to set the number of thread for event synthesize
> >   perf top: switch back to overwrite mode
> >
> >  tools/perf/builtin-kvm.c              |   3 +-
> >  tools/perf/builtin-record.c           |   2 +-
> >  tools/perf/builtin-top.c              |   9 +-
> >  tools/perf/builtin-trace.c            |  21 +++--
> >  tools/perf/tests/mmap-thread-lookup.c |   2 +-
> >  tools/perf/ui/browsers/hists.c        |   2 +-
> >  tools/perf/util/comm.c                |  18 +++-
> >  tools/perf/util/event.c               | 149 +++++++++++++++++++++++++-------
> >  tools/perf/util/event.h               |  14 ++-
> >  tools/perf/util/evlist.c              |   5 +-
> >  tools/perf/util/hist.c                |  11 +--
> >  tools/perf/util/machine.c             | 158 +++++++++++++++++++++-------------
> >  tools/perf/util/machine.h             |  34 ++++++--
> >  tools/perf/util/rb_resort.h           |   5 +-
> >  tools/perf/util/sort.c                |   8 +-
> >  tools/perf/util/sort.h                |   2 +-
> >  tools/perf/util/thread.c              |  68 ++++++++++++---
> >  tools/perf/util/thread.h              |   6 +-
> >  tools/perf/util/top.h                 |   1 +
> >  19 files changed, 376 insertions(+), 142 deletions(-)
> >
> > --
> > 2.5.5