linux-kernel - Re: [PATCH] signal: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Sep 2017 08:36:05 +0100
From:   Christos Gkekas <chris.gekas@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signal: remove unused variable

On 11/09/17 22:03:37 +0200, Arnd Bergmann wrote:
> The get_compat_sigset() cleanup missed a variable that is now unused:
> 
> kernel/signal.c: In function 'C_SYSC_rt_sigaction':
> kernel/signal.c:3443:19: error: unused variable 'mask' [-Werror=unused-variable]
> 
> Fixes: 9b24ec57688a ("get_compat_sigset()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  kernel/signal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 3198a7d2e5ff..36a523640894 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -3440,7 +3440,6 @@ COMPAT_SYSCALL_DEFINE4(rt_sigaction, int, sig,
>  
>  	if (act) {
>  		compat_uptr_t handler;
> -		compat_sigset_t mask;
>  		ret = get_user(handler, &act->sa_handler);
>  		new_ka.sa.sa_handler = compat_ptr(handler);
>  #ifdef __ARCH_HAS_SA_RESTORER
> -- 
> 2.9.0
>


Thanks,

Acked-by: Christos Gkekas <chris.gekas@...il.com>