linux-kernel - Re: [PATCH v4 1/2] wire: export w1_touch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 21:37:45 +0200
From:   GregKH <greg@...ah.com>
To:     Jan Kandziora <jjj@....de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Evgeniy Polyakov <zbr@...emap.net>,
        Linux-I2C <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] wire: export w1_touch_bit

On Mon, Sep 18, 2017 at 09:34:27PM +0200, Jan Kandziora wrote:
> Am 18.09.2017 um 16:19 schrieb GregKH:
> > On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote:
> >> The w1_ds28e17 driver from the next part of this patch needs to emit
> >> single-bit read timeslots to the DS28E17. The w1 subsystem already
> >> has this function but it is not exported outside drivers/w1/w1_io.c
> >>
> >> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
> >> same as the other exported symbols in drivers/w1/w1_io.c
> >>
> >> May be also useful later for writing drivers for other Onewire chips
> >> which do single-bit communication.
> >>
> >> Signed-off-by: Jan Kandziora <jjj@....de>
> >> Acked-by: Evgeniy Polyakov <zbr@...emap.net>
> >> ---
> >> Changes in v4 against v3 in this subpatch:
> >>   - adapted to linux-4.12.0
> >>
> >> No changes in v3 against v2,v1 in this subpatch.
> > 
> > You should change it as it does not apply to 4.14-rc1 :(
> > 
> Okay, I will review them again.
> 
> 
> > Please rebase your patches and resend them, with Evgeniy's acks added to
> > them.
> > 
> Now you caught me. I don't know how to do that. What's required? The
> Acked-by: line? Am I allowed to simply add these lines to my patches or
> is there a procedure to follow?

Just add the acked-by line, like I did above, and all should be fine.

thanks,

greg k-h