linux-kernel - Re: linux-next: Signed-off-by missing for commits in the staging tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Sep 2017 01:50:48 +1000
From:   Tobin Harding <me@...in.cc>
To:     Greg KH <greg@...ah.com>, Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     "Linux-Next Mailing List" <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commits in the staging tree


On Wed, Sep 20, 2017, at 01:34, Tobin Harding wrote:
> 
> On Tue, Sep 19, 2017, at 16:09, Greg KH wrote:
> > On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > Commits
> > > 
> > >   688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
> > >   85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
> > >   f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
> > > 
> > > are missing a Signed-off-by from their author.
> > 
> > Ugh, I totally missed that, Tobin, what went wrong here?
> 
> Apologies, I bet I didn't set up my environment on the laptop fully.
> Usual dev machine is a desktop, I did these patches as prep for OSS. 

I've got a strong feeling I didn't enable the driver before I 'built'
this patch series also.  Bad Tobin.

Luckily the kbot didn't punish me.