linux-kernel - Re: [PATCH] x86/pci/intel_mid_pci: make intel_mid_pci_ops const and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Sep 2017 14:45:32 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, bhelgaas@...gle.com, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, x86@...nel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/pci/intel_mid_pci: make intel_mid_pci_ops const and
 __initconst

On Mon, Sep 18, 2017 at 09:54:55PM +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation. This usage
> is inside init function and the structure is not referenced after
> initialisation, so make it __initconst too.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

I applied this to pci/misc for v4.15, thanks!

If this conflicts with patches going via x86, I'll gladly drop it from my
tree; just let me know.

> ---
>  arch/x86/pci/intel_mid_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
> index b901ece..63fbe8f 100644
> --- a/arch/x86/pci/intel_mid_pci.c
> +++ b/arch/x86/pci/intel_mid_pci.c
> @@ -279,7 +279,7 @@ static void intel_mid_pci_irq_disable(struct pci_dev *dev)
>  	}
>  }
>  
> -static struct pci_ops intel_mid_pci_ops = {
> +static const struct pci_ops intel_mid_pci_ops __initconst = {
>  	.read = pci_read,
>  	.write = pci_write,
>  };
> -- 
> 1.9.1
>