linux-kernel - Re: [PATCH] fpga: make xlnx_pr_decoupler_br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Sep 2017 09:42:46 -0500
From:   Alan Tull <atull@...nel.org>
To:     Moritz Fischer <moritz.fischer@...us.com>
Cc:     Michal Simek <michal.simek@...inx.com>,
        Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        linux-fpga@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer
<moritz.fischer@...us.com> wrote:
> On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@...inx.com> wrote:
>> On 28.8.2017 19:32, Bhumika Goyal wrote:
>>> Make this const as it is only passed to a const argument of the function
>>> fpga_bridge_register.
>>>
>>> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
>
> Acked-by: Moritz Fischer <mdf@...nel.org>
>>> ---
>>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>>> index e359930..0d77430 100644
>>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>>       return !status;
>>>  }
>>>
>>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>>  };
>
> Must've been a leftover from when I worked on integrating a simple
> GPIO based one.
> I'll have to rebase that and submit it.
>>>
>>
>> Acked-by: Michal Simek <michal.simek@...inx.com>
Signed-off-by: Alan Tull <atull@...nel.org>
>>
>> Thanks,
>> Michal
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Thanks,
> Moritz