linux-kernel - Re: [RFC PATCH 5/7] sound: core: Avoid using timespec for struct snd_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Sep 2017 10:03:07 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Dan Carpenter <dan.carpenter@...cle.com>, jeeja.kp@...el.com,
        Vinod Koul <vinod.koul@...el.com>, dharageswari.r@...el.com,
        guneshwor.o.singh@...el.com, Bhumika Goyal <bhumirks@...il.com>,
        gudishax.kranthikumar@...el.com, Naveen M <naveen.m@...el.com>,
        hardik.t.shah@...el.com, Arvind Yadav <arvind.yadav.cs@...il.com>,
        Fabian Frederick <fabf@...net.be>,
        Mark Brown <broonie@...nel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        alsa-devel@...a-project.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 5/7] sound: core: Avoid using timespec for struct snd_timer_status

On 21 September 2017 at 21:14, Arnd Bergmann <arnd@...db.de> wrote:
> On Thu, Sep 21, 2017 at 8:18 AM, Baolin Wang <baolin.wang@...aro.org> wrote:
>
>>  static long snd_timer_user_ioctl_compat(struct file *file, unsigned int cmd, unsigned long arg)
>> @@ -158,12 +151,10 @@ static long snd_timer_user_ioctl_compat(struct file *file, unsigned int cmd, uns
>>                 return snd_timer_user_gparams_compat(file, argp);
>>         case SNDRV_TIMER_IOCTL_INFO32:
>>                 return snd_timer_user_info_compat(file, argp);
>> -       case SNDRV_TIMER_IOCTL_STATUS32:
>> +       case SNDRV_TIMER_IOCTL_STATUS_COMPAT32:
>>                 return snd_timer_user_status_compat(file, argp);
>> -#ifdef CONFIG_X86_X32
>> -       case SNDRV_TIMER_IOCTL_STATUS_X32:
>> -               return snd_timer_user_status_x32(file, argp);
>> -#endif /* CONFIG_X86_X32 */
>> +       case SNDRV_TIMER_IOCTL_STATUS_COMPAT64:
>> +               return snd_timer_user_status64(file, argp);
>>         }
>
> I think the last line would fail to build since snd_timer_user_status64()
> is defined 'static' in a different file.

I saw the timer_compat.c file will be included into timer.c file, so I
think it will not. (My arm32 platform can not build compat mode, but I
will try again to make sure it can build successfully.)

>
> Also, snd_timer_user_status_compat() seems to be the same as
> snd_timer_user_status32(), so I think you can redirect it the same
> way as snd_timer_user_status64 after making both functions globally
> visible.

OK. Let me check again.

-- 
Baolin.wang
Best Regards