linux-kernel - Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Sep 2017 10:20:06 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Marek Vasut <marek.vasut@...il.com>
Cc:     Pavel Machek <pavel@....cz>, dwmw2@...radead.org,
        computersforpeace@...il.com, richard@....at,
        cyrille.pitchen@...ev4u.fr, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h

On Sat, 23 Sep 2017 23:10:26 +0200
Marek Vasut <marek.vasut@...il.com> wrote:

> On 09/23/2017 10:13 PM, Pavel Machek wrote:
> > C++ comments look wrong in kernel tree. Fix one.  
> 
> AFAIR they are now (sadly) accepted, but this patch works for me.

Works for me too. Here is my

Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

> Would be nice if trivial could pick it.

Hm, I'd recommend not doing that, otherwise we might end up with a
conflict if a patch modify something in this area.

> 
> > Signed-off-by: Pavel Machek <pavel@....cz>
> > 
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 6cd0f6b..849543f1 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -267,7 +267,7 @@ struct mtd_info {
> >  	 */
> >  	unsigned int bitflip_threshold;
> >  
> > -	// Kernel-only stuff starts here.
> > +	/* Kernel-only stuff starts here. */
> >  	const char *name;
> >  	int index;
> >  
> >   
> 
>