linux-kernel - Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Sep 2017 06:16:33 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     "rafael@...nel.org" <rafael@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.

	On Mon, 2017-09-25 at 00:37 +0200, Rafael J. Wysocki wrote:
> On Sun, Sep 24, 2017 at 10:35 AM, Tomas Winkler <tomas.winkler@...el.com> wrote:
> > From: Alexander Usyskin <alexander.usyskin@...el.com>
> > 
> > This patch fixes a regression caused by the new changes
> > in the run wake handlers, pci_dev_run_wake() return true
> > when wake is possible from the software perspective
> > not whether it is actually enabled.
> 
> This isn't exactly accurate, because "run wake" used to mean "wakeup
> signals can be generated for this device in the working state of the
> system", so it could not be enabled or disabled before too.  It's just
> that the function returns "true" for (at least) some devices for which
> it used to return "false" (arguably incorrectly).
> 
> Other than that I agree with the patch.

Thanks for the correction, I will respin the patch with your
explanation.

Thanks
Tomas