linux-kernel - Re: [PATCH 0/3] This patchset refactors event related functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Sep 2017 08:23:50 +0200
From:   Martin Kepplinger <martink@...teo.de>
To:     Harinath Nampally <harinath922@...il.com>
Cc:     jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, gregkh@...uxfoundation.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        amsfield22@...il.com
Subject: Re: [PATCH 0/3] This patchset refactors event related functions

Am 25.09.2017 05:15 schrieb Harinath Nampally:
> Harinath Nampally (3):
> Following 2 patches are for refactor:
>   iio: accel: mma8452: Rename time step look up struct     to generic
>     name as the values are same for all the events.
>   iio: accel: mma8452: Rename read/write event value     callbacks to
>     generic function name.
> Following patch adds new feature:
>   iio: accel: mma8452: Add single pulse/tap event detection     feature
>     for fxls8471.
> 

I guess it's fine for now, but please don't call your patchset "This 
patchset does...".
Just say "Refactor..." or whatever like you do in your patches.