linux-kernel - Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Sep 2017 18:47:14 +0530
From:   PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Paul Cercueil <paul@...pouillou.net>,
        devicetree@...r.kernel.org, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog
 driver from devicetree

Hi Mathieu,

On 16 September 2017 at 00:48, Mathieu Malaterre <malat@...ian.org> wrote:
> The jz4740-watchdog driver supports both jz4740 & jz4780.
>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
> Changes in v2:
> * make the node name generic (Paul Cercueil)
>
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 20e37d2d6008..76055bbc823a 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -263,6 +263,11 @@
>                 status = "disabled";
>         };
>
> +       watchdog: watchdog@...02000 {
> +               compatible = "ingenic,jz4780-watchdog";

In drivers/watchdog/jz4740_wdt.c the compatible is declared as
"ingenic,jz4740-watchdog" while your change says
"ingenic,jz4780-watchdog". Can you modify that?

> +               reg = <0x10002000 0x100>;
> +       };
> +

The structures jz4740_wdt_device and jz4740_wdt_resources can be
removed form arch/mips/jz4740/platform.c as watchdog is declared in
device tree. For JZ4740 platform watchdog is not used so the variables
can be removed.

Do you mind adding watchdog entry to JZ4740 device tree? Currently
watchdog is not enabled for JZ4740 platform.

>         nemc: nemc@...10000 {
>                 compatible = "ingenic,jz4780-nemc";
>                 reg = <0x13410000 0x10000>;
> --
> 2.11.0
>

Regards,
PrasannaKumar