linux-kernel - Re: [PATCH] ACPI / PCI: Bail early in acpi_pci_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Sep 2017 22:21:38 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>, linux-acpi@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Len Brown <lenb@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jork Loeser <jloeser@...rosoft.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH] ACPI / PCI: Bail early in acpi_pci_add_bus() if there is no ACPI handle

On Tuesday, September 26, 2017 10:25:08 PM CEST Bjorn Helgaas wrote:
> On Thu, Sep 14, 2017 at 04:50:14PM +0200, Vitaly Kuznetsov wrote:
> > Hyper-V instances support PCI pass-through which is implemented through
> > PV pci-hyperv driver. When a device is passed through a new root PCI bus
> > is created in the guest. The bus sits on top of VMBus and has no
> > associated information in ACPI. acpi_pci_add_bus() in this case proceeds
> > all the way to acpi_evaluate_dsm() with reports
> > 
> >     ACPI: \: failed to evaluate _DSM (0x1001)
> > 
> > While acpi_pci_slot_enumerate() and acpiphp_enumerate_slots() are protected
> > against ACPI_HANDLE() being NULL and do nothing acpi_evaluate_dsm() is not
> > and gives us the error. It seems the correct fix is to not do anything in
> > acpi_pci_add_bus() in such cases.
> > 
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> 
> Applied to pci/acpi for v4.15, thanks!
> 
> Rafael, let me know if you have any objections or if you'd rather take
> it yourself.

No objections, all is fine.

Thanks,
Rafael