lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Sep 2017 20:44:26 -0600 From: David Ahern <dsahern@...il.com> To: 禹舟键 <ufo19890607@...il.com>, Jiri Olsa <jolsa@...hat.com> Cc: peterz@...radead.org, mingo@...hat.com, alexander.shishkin@...ux.intel.com, jolsa@...nel.org, namhyung@...nel.org, Milian Wolff <milian.wolff@...b.com>, Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>, Wind Yu <yuzhoujian@...ichuxing.com>, linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script On 9/25/17 8:41 PM, 禹舟键 wrote: > The changelogs are in the cover-letter. > changes in v2: > - remove the set of script.tool.per_event_dump variable. > - add the __maybe_unused attribute for the fp argument in the > second patch. > - remove the fp_selection_helper function for setting the fp > argument. > - split the original second patch(Makes all those related > functions receive the FILE pointer) to two patches. > - modify the file name of per-event-dump to <ORIGINAL PERF DATA > FILE NAME>-script-dump-<EVENT NAME>.txt Each patch should have a single focus and a changelog describing what is changed and why. Impacts to the user experience should have example output.
Powered by blists - more mailing lists