linux-kernel - Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2017 09:14:45 +0800
From:   Chaotian Jing <chaotian.jing@...iatek.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        yong mao <yong.mao@...iatek.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "Javier Martinez Canillas" <javier@....samsung.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Phong LE <ple@...libre.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        srv_heupstream <srv_heupstream@...iatek.com>
Subject: Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc"
 from mmc nodes

On Wed, 2017-09-27 at 00:37 +0200, Ulf Hansson wrote:
> On 12 September 2017 at 11:07, Chaotian Jing <chaotian.jing@...iatek.com> wrote:
> > devicetree bindings has been updated to support multi-platforms,
> > so that each platform has its owns compatible name.
> > And, this compatible name may used in driver to distinguish with
> > other platform.
> 
> This does not seems to be DT backwards compatible.
> 
> If the driver starts interpreting the "mt8135-mmc" differently,
> wouldn't that lead to old DTBs to become broken?
> 
> Kind regards
> Uffe
At patch 03/12, it shows that no difference between "mt8135-mmc" and
"mt8173-mmc", and following changes will make difference between these
two.
but, the user should update DTS & driver together,then will do not have
compatible issue.
> 
> >
> > Signed-off-by: Chaotian Jing <chaotian.jing@...iatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++--------
> >  1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index b99a273..26396ef 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -682,8 +682,7 @@
> >                 };
> >
> >                 mmc0: mmc@...30000 {
> > -                       compatible = "mediatek,mt8173-mmc",
> > -                                    "mediatek,mt8135-mmc";
> > +                       compatible = "mediatek,mt8173-mmc";
> >                         reg = <0 0x11230000 0 0x1000>;
> >                         interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_LOW>;
> >                         clocks = <&pericfg CLK_PERI_MSDC30_0>,
> > @@ -693,8 +692,7 @@
> >                 };
> >
> >                 mmc1: mmc@...40000 {
> > -                       compatible = "mediatek,mt8173-mmc",
> > -                                    "mediatek,mt8135-mmc";
> > +                       compatible = "mediatek,mt8173-mmc";
> >                         reg = <0 0x11240000 0 0x1000>;
> >                         interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_LOW>;
> >                         clocks = <&pericfg CLK_PERI_MSDC30_1>,
> > @@ -704,8 +702,7 @@
> >                 };
> >
> >                 mmc2: mmc@...50000 {
> > -                       compatible = "mediatek,mt8173-mmc",
> > -                                    "mediatek,mt8135-mmc";
> > +                       compatible = "mediatek,mt8173-mmc";
> >                         reg = <0 0x11250000 0 0x1000>;
> >                         interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_LOW>;
> >                         clocks = <&pericfg CLK_PERI_MSDC30_2>,
> > @@ -715,8 +712,7 @@
> >                 };
> >
> >                 mmc3: mmc@...60000 {
> > -                       compatible = "mediatek,mt8173-mmc",
> > -                                    "mediatek,mt8135-mmc";
> > +                       compatible = "mediatek,mt8173-mmc";
> >                         reg = <0 0x11260000 0 0x1000>;
> >                         interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
> >                         clocks = <&pericfg CLK_PERI_MSDC30_3>,
> > --
> > 1.8.1.1.dirty
> >