linux-kernel - Re: [PATCH 3/3] clk/mmp: Adjust 12 checks for null pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2017 11:26:53 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-clk@...r.kernel.org, Chao Xie <chao.xie@...vell.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3] clk/mmp: Adjust 12 checks for null pointers

On 09/27/2017 09:27 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 27 Sep 2017 09:00:21 +0200

> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit

Can you please fix your process and stop posting with above tags 
in the commit message? These 3 tags are already in the header
of message you are sending. After your patches get applied 
we end up with a mess in commit messages as below.

------------------------------8<-------------------------------
commit 0b08273c8ab7e688832120c4817b1adfdc56e231
Author: Markus Elfring <elfring@...rs.sourceforge.net>
Date:   Thu Aug 17 21:35:16 2017 +0200

    orangefs: Adjust three checks for null pointers
    
    MIME-Version: 1.0
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: 8bit
    
    The script “checkpatch.pl” pointed information out like the following.
    
    Comparison to NULL could be written !…
    
    Thus fix affected source code places.
    
    Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
    Signed-off-by: Mike Marshall <hubcap@...ibond.com>
------------------------------8<-------------------------------

Please see "DISCUSSION" paragraph of [1] for an explanation 
of what should be put in the message body.

[1] https://git-scm.com/docs/git-format-patch

--
Thanks,
Sylwester

> The script “checkpatch.pl” pointed information out like the following.
> 
> Comparison to NULL could be written !…
> 
> Thus fix the affected source code places.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>