lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Sep 2017 12:57:28 +0800 From: "Wei Hu (Xavier)" <xavier.huwei@...wei.com> To: <dledford@...hat.com> CC: <linux-rdma@...r.kernel.org>, <xavier.huwei@...wei.com>, <lijun_nudt@....com>, <oulijun@...wei.com>, <charles.chenxin@...wei.com>, <liuyixian@...wei.com>, <xushaobo2@...wei.com>, <zhangxiping3@...wei.com>, <xavier.huwei@....com>, <linuxarm@...wei.com>, <linux-kernel@...r.kernel.org>, <shaobohsu@....com> Subject: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp From: Lijun Ou <oulijun@...wei.com> When lp_qp_work is NULL, it should be returned ENOMEM. This patch mainly fixes it. Ihis patch fixes the smatch error as below: drivers/infiniband/hw/hns/hns_roce_hw_v1.c:918 hns_roce_v1_recreate_lp_qp() error: potential null dereference 'lp_qp_work'. (kzalloc returns null) Signed-off-by: Lijun Ou <oulijun@...wei.com> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@...wei.com> Signed-off-by: Shaobo Xu <xushaobo2@...wei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c index 95f5c88..1071fa2 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c @@ -912,6 +912,8 @@ static int hns_roce_v1_recreate_lp_qp(struct hns_roce_dev *hr_dev) lp_qp_work = kzalloc(sizeof(struct hns_roce_recreate_lp_qp_work), GFP_KERNEL); + if (!lp_qp_work) + return -ENOMEM; INIT_WORK(&(lp_qp_work->work), hns_roce_v1_recreate_lp_qp_work_fn); -- 1.9.1
Powered by blists - more mailing lists