linux-kernel - Re: [PATCH 1/6] lightnvm: pblk: remove useless line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Oct 2017 13:29:30 +0200
From:   Javier González <jg@...htnvm.io>
To:     Rakesh Pandit <rakesh@...era.com>
Cc:     Matias Bjørling <mb@...htnvm.io>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] lightnvm: pblk: remove useless line

> On 1 Oct 2017, at 15.23, Rakesh Pandit <rakesh@...era.com> wrote:
> 
> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
> ---
> drivers/lightnvm/pblk-core.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 1f8aa94..4ffd1d6 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1053,7 +1053,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
> 	/* Mark emeta metadata sectors as bad sectors. We need to consider bad
> 	 * blocks to make sure that there are enough sectors to store emeta
> 	 */
> -	bit = lm->sec_per_line;
> 	off = lm->sec_per_line - lm->emeta_sec[0];
> 	bitmap_set(line->invalid_bitmap, off, lm->emeta_sec[0]);
> 	while (nr_bb) {
> --
> 2.7.4

LGTM

Reviewed-by: Javier González <javier@...xlabs.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)