linux-kernel - Re: [PATCH 0/3 v2 RESEND] x86/smpboot: Cleanup logical package ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Oct 2017 11:13:05 -0400
From:   Prarit Bhargava <prarit@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Piotr Luc <piotr.luc@...el.com>,
        Kan Liang <kan.liang@...el.com>, Borislav Petkov <bp@...e.de>,
        Stephane Eranian <eranian@...gle.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Andy Lutomirski <luto@...nel.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        He Chen <he.chen@...ux.intel.com>,
        Mathias Krause <minipli@...glemail.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Subject: Re: [PATCH 0/3 v2 RESEND] x86/smpboot: Cleanup logical package ID



On 09/26/2017 08:53 AM, Prarit Bhargava wrote:
> Sending to wider audience.  I originally sent this to only the people Andi
> had cc'd.

Here's an example of the panic:

    smpboot: Booting Node   1, Processors  #1 OK
    smpboot: Package 1 of CPU 1 exceeds BIOS package data 1.
    ------------[ cut here ]------------
    kernel BUG at arch/x86/kernel/cpu/common.c:1087!
    invalid opcode: 0000 [#1] SMP
    Modules linked in:
    CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.14.0-rc2+ #4


> 
> Andi posted two patches to clean up the logical package ID, and I posted a
> bug fix for systems which boot with less than than the maximum core count.
> If I take his changes into account the code base ends up with a significant
> cleanup.  I am reposting his patches here.
> 
> I boot tested this using max_cpus and nr_cpus, as well as booting on
> systems which panic without the fix in 3/3.
> 
> ---8<---
> 
> Cleanup the logical package ID code by storing the logical package ID in
> the cpuinfo_x86 struct and calculating the maximum logical package ID
> after all the CPUs have been enumerated.
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Dave Hansen <dave.hansen@...el.com>
> Cc: Piotr Luc <piotr.luc@...el.com>
> Cc: Kan Liang <kan.liang@...el.com>
> Cc: Borislav Petkov <bp@...e.de>
> Cc: Stephane Eranian <eranian@...gle.com>
> Cc: Prarit Bhargava <prarit@...hat.com>
> Cc: Arvind Yadav <arvind.yadav.cs@...il.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
> Cc: Tom Lendacky <thomas.lendacky@....com>
> Cc: He Chen <he.chen@...ux.intel.com>
> Cc: Mathias Krause <minipli@...glemail.com>
> Cc: Tim Chen <tim.c.chen@...ux.intel.com>
> Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
> 
> Andi Kleen (2):
>   perf/x86/intel/uncore: Cache logical pkg id in uncore driver
>   x86/topology: Avoid wasting 128k for package id array
> 
> Prarit Bhargava (1):
>   x86/smpboot: Fix __max_logical_packages estimate
> 
>  arch/x86/events/intel/uncore.c       |   1 +
>  arch/x86/events/intel/uncore.h       |   1 +
>  arch/x86/events/intel/uncore_snbep.c |   2 +-
>  arch/x86/include/asm/processor.h     |   6 +-
>  arch/x86/kernel/smpboot.c            | 113 +++++++++++------------------------
>  5 files changed, 42 insertions(+), 81 deletions(-)
>