linux-kernel - Re: [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Oct 2017 08:20:40 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        gregkh@...uxfoundation.org, jacobvonchorus@...hoto.ca,
        mchehab@...nel.org, eric@...olt.net, f.fainelli@...il.com,
        rjui@...adcom.com, Larry.Finger@...inger.net, pkshih@...ltek.com
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end
 with newlines

Am 03.10.2017 um 13:43 schrieb Arvind Yadav:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Acked-by: Stefan Wahren <stefan.wahren@...e.com>

> ---
>  drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 4360db6..6ea7fb0 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -1963,7 +1963,7 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
>  
>  	status = vchi_service_close(instance->handle);
>  	if (status != 0)
> -		pr_err("mmal-vchiq: VCHIQ close failed");
> +		pr_err("mmal-vchiq: VCHIQ close failed\n");
>  
>  	mutex_unlock(&instance->vchiq_mutex);
>