linux-kernel - Re: [PATCH v2 9/9] ARM: dts: aspeed: Clean up UART nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 05 Oct 2017 10:09:10 +1030
From:   Andrew Jeffery <andrew@...id.au>
To:     Joel Stanley <joel@....id.au>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Cc:     Russell King <linux@...linux.org.uk>,
        devicetree <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rick Altherr <raltherr@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Cédric Le Goater <clg@...d.org>,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH v2 9/9] ARM: dts: aspeed: Clean up UART nodes

On Wed, 2017-10-04 at 16:22 +0930, Joel Stanley wrote:
> > On Wed, Oct 4, 2017 at 4:19 PM, Joel Stanley <joel@....id.au> wrote:
> 
> > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> > index 61cc2d25143a..cef51dcc1002 100644
> > --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> > @@ -297,9 +297,9 @@
> >                                 };
> >                         };
> > 
> > -                       uart6: serial@...87000 {
> > -                               compatible = "ns16550a";
> > -                               reg = <0x1e787000 0x1000>;
> > +                       vuart: vuart@...87000 {
> 
> Doh. I'll fix this up when I apply, assuming I don't need to send a v3.

In that case:

Reviewed-by: Andrew Jeffery <andrew@...id.au>

> 
> 
> > +                               compatible = "aspeed,ast2500-vuart";
> > +                               reg = <0x1e787000 0x40>;
> >                                 reg-shift = <2>;
> >                                 interrupts = <10>;
> >                                 clocks = <&clk_uart>;
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)