linux-kernel - Re: [PATCH] mm, arch: remove empty_bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 12:02:53 +0200
From:   Ralf Baechle <ralf@...ux-mips.org>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Michal Hocko <mhocko@...e.com>,
        David Howells <dhowells@...hat.com>,
        Ingo Molnar <mingo@...nel.org>, Jeff Dike <jdike@...toit.com>,
        linux-mips@...ux-mips.org, linux-sh@...r.kernel.org,
        Richard Weinberger <richard@....at>,
        Rich Felker <dalias@...c.org>,
        uclinux-h8-devel@...ts.sourceforge.jp,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>
Subject: Re: [PATCH] mm, arch: remove empty_bad_page*

On Wed, Oct 04, 2017 at 05:00:45PM +0200, Michal Hocko wrote:

> From: Michal Hocko <mhocko@...e.com>
> 
> empty_bad_page and empty_bad_pte_table seems to be a relict from old
> days which is not used by any code for a long time. I have tried to find
> when exactly but this is not really all that straightforward due to many
> code movements - traces disappear around 2.4 times.
> 
> Anyway no code really references neither empty_bad_page nor
> empty_bad_pte_table. We only allocate the storage which is not used by
> anybody so remove them.
> 
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Rich Felker <dalias@...c.org>
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: <uclinux-h8-devel@...ts.sourceforge.jp>
> Cc: <linux-mips@...ux-mips.org>
> Cc: <linux-sh@...r.kernel.org>
> Signed-off-by: Michal Hocko <mhocko@...e.com>

On MIPS the empty_bad_page_table definition was deleted in 2549fa57708d
("Small cleanups including deletion of two variables 4k each ...") in the
MIPS git tree on 2003-07-29, so

Acked-by: Ralf Baechle <ralf@...us-mips.org>

for getting rid of the rest a mere 14 years later.

Thanks,

  Ralf