linux-kernel - Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 08:17:28 -0700
From:   Mark Greer <mgreer@...malcreek.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        Vaibhav Agarwal <vaibhav.sr@...il.com>,
        Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.

On Thu, Oct 05, 2017 at 02:56:54PM +0200, Sebastian Andrzej Siewior wrote:
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. One thing it does is to break the RT build.
> 
> Cc: Vaibhav Agarwal <vaibhav.sr@...il.com>
> Cc: Mark Greer <mgreer@...malcreek.com>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alex Elder <elder@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: greybus-dev@...ts.linaro.org
> Cc: devel@...verdev.osuosl.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  drivers/staging/greybus/audio_manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index aa6508b44fab..045696ce85c7 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -10,7 +10,7 @@
>  #include <linux/sysfs.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
> -#include <linux/rwlock.h>
> +#include <linux/spinlock.h>
>  #include <linux/idr.h>
>  
>  #include "audio_manager.h"
> -- 
> 2.14.2

Thanks for the patch.

Reviewed-by: Mark Greer <mgreer@...malcreek.com>