linux-kernel - Re: [PATCH] x86/tsc: Append description for 'tsc=unstable' boot parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Oct 2017 08:25:55 -0400
From:   Pavel Tatashin <pasha.tatashin@...cle.com>
To:     Dou Liyang <douly.fnst@...fujitsu.com>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        corbet@....net, tglx@...utronix.de, mingo@...nel.org,
        peterz@...radead.org, x86@...nel.org
Subject: Re: [PATCH] x86/tsc: Append description for 'tsc=unstable' boot parameter

Hi Dou,

Have you tested tsc=unstable with your DR setup? Is it working as
expected? I mean instead of previous "notsc"?

Reviewed-by: Pavel Tatashin <pasha.tatashin@...cle.com>

Thank you,
Pavel

On Mon, Oct 9, 2017 at 5:03 AM, Dou Liyang <douly.fnst@...fujitsu.com> wrote:
> Commit 8309f86cd41e ("x86/tsc: Provide 'tsc=unstable' boot parameter") adds
> a new parameter 'tsc=unstable', but doesn't add some description to guide
> users.
>
> Append the description of 'tsc=unstable' at the end of 'tsc=' section.
>
> Signed-off-by: Dou Liyang <douly.fnst@...fujitsu.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 9a84483..33e83b6 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4196,6 +4196,9 @@
>                         Used to run time disable IRQ_TIME_ACCOUNTING on any
>                         platforms where RDTSC is slow and this accounting
>                         can add overhead.
> +                       [x86] unstable: mark tsc clocksource as unstable, this
> +                       marks the TSC unconditionally unstable at bootup and
> +                       avoids any further wobbles once the TSC watchdog notices.
>
>         turbografx.map[2|3]=    [HW,JOY]
>                         TurboGraFX parallel port interface
> --
> 2.5.5
>
>
>