linux-kernel - Re: [PATCH] block: add partition uuid into uevent as "PARTUUID"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 16:57:07 -0400
From:   Kyle Fortin <kyle.fortin@...cle.com>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     linux-block@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: add partition uuid into uevent as "PARTUUID"

Hi Konstantin,

> On Oct 6, 2017, at 7:42 AM, Konstantin Khlebnikov <khlebnikov@...dex-team.ru> wrote:
> 
> Both most common formats have uuid in addition to partition name:
> GPT: standard uuid xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
> DOS: 4 byte disk signature and 1 byte partition xxxxxxxx-xx
> 
> Tools from util-linux use the same notation for them.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> ---
> block/partition-generic.c |    2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/block/partition-generic.c b/block/partition-generic.c
> index 88c555db4e5d..8f8b580aee16 100644
> --- a/block/partition-generic.c
> +++ b/block/partition-generic.c
> @@ -226,6 +226,8 @@ static int part_uevent(struct device *dev, struct kobj_uevent_env *env)
> 	add_uevent_var(env, "PARTN=%u", part->partno);
> 	if (part->info && part->info->volname[0])
> 		add_uevent_var(env, "PARTNAME=%s", part->info->volname);
> +	if (part->info && part->info->uuid[0])
> +		add_uevent_var(env, "PARTUUID=%s", part->info->uuid);
> 	return 0;
> }

Looks fine.

Reviewed-by: Kyle Fortin <kyle.fortin@...cle.com>