linux-kernel - Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 10:24:45 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Joe Perches <joe@...ches.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>, rui.zhang@...el.com,
        edubezval@...il.com
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings
 should end with newlines

On 10/10/2017 06:37, Joe Perches wrote:
> On Mon, 2017-10-09 at 14:33 +0200, Daniel Lezcano wrote:
>> On 09/10/2017 13:51, Arvind Yadav wrote:
>>> pr_err()/pr_info() messages should end with a new-line to avoid
>>> other messages being concatenated.
> []
>>> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
>>> @@ -675,13 +675,13 @@ static int __init powerclamp_probe(void)
>>>  {
>>>  
>>>  	if (!x86_match_cpu(intel_powerclamp_ids)) {
>>> -		pr_err("CPU does not support MWAIT");
>>> +		pr_err("CPU does not support MWAIT\n");
> 
> [etc...]
> 
>> Hi Arvind,
>>
>> you are sending these fixes for all the drivers around. There is a way
>> to fix this once and for all: use the coccinelle tools [1], add the
>> script in the changelog with a big patchset and add the script in the
>> coccinelle scripts directory [2].
> 
> That can't work as any printk without a newline termination
> could be followed by a printk(KERN_CONT/pr_cont( in another
> function.
> 
> All of these must be hand-verified.

Ouch!

Fair enough. Thanks for the info.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog