linux-kernel - Re: [PATCH -mm] mm, swap: Use page-cluster as max window of VMA based swap readahead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 17:55:24 +0900
From:   Minchan Kim <minchan@...nel.org>
To:     "Huang, Ying" <ying.huang@...el.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
        Rik van Riel <riel@...hat.com>, Shaohua Li <shli@...nel.org>,
        Hugh Dickins <hughd@...gle.com>,
        Fengguang Wu <fengguang.wu@...el.com>,
        Tim Chen <tim.c.chen@...el.com>,
        Dave Hansen <dave.hansen@...el.com>
Subject: Re: [PATCH -mm] mm, swap: Use page-cluster as max window of VMA
 based swap readahead

On Tue, Oct 10, 2017 at 04:50:10PM +0800, Huang, Ying wrote:
> Minchan Kim <minchan@...nel.org> writes:
> 
> > On Tue, Oct 10, 2017 at 02:08:55PM +0800, Huang, Ying wrote:
> >> From: Huang Ying <ying.huang@...el.com>
> >> 
> >> When the VMA based swap readahead was introduced, a new knob
> >> 
> >>   /sys/kernel/mm/swap/vma_ra_max_order
> >> 
> >> was added as the max window of VMA swap readahead.  This is to make it
> >> possible to use different max window for VMA based readahead and
> >> original physical readahead.  But Minchan Kim pointed out that this
> >> will cause a regression because setting page-cluster sysctl to zero
> >> cannot disable swap readahead with the change.
> >> 
> >> To fix the regression, the page-cluster sysctl is used as the max
> >> window of both the VMA based swap readahead and original physical swap
> >> readahead.  If more fine grained control is needed in the future, more
> >> knobs can be added as the subordinate knobs of the page-cluster
> >> sysctl.
> >> 
> >> The vma_ra_max_order knob is deleted.  Because the knob was
> >> introduced in v4.14-rc1, and this patch is targeting being merged
> >> before v4.14 releasing, there should be no existing users of this
> >> newly added ABI.
> >> 
> >> Cc: Johannes Weiner <hannes@...xchg.org>
> >> Cc: Rik van Riel <riel@...hat.com>
> >> Cc: Shaohua Li <shli@...nel.org>
> >> Cc: Hugh Dickins <hughd@...gle.com>
> >> Cc: Fengguang Wu <fengguang.wu@...el.com>
> >> Cc: Tim Chen <tim.c.chen@...el.com>
> >> Cc: Dave Hansen <dave.hansen@...el.com>
> >> Reported-by: Minchan Kim <minchan@...nel.org>
> >
> > It seems your script is Ccing only with Cc: tag, not other tags.
> > Fix it so any participant of topic can get the mail.
> 
> I just used `git send-email`, no other scripts.  We need to fix `git send-email`?

You can do it via cccmd.

Just a reference:

~/bin/kcccmd
sed -nre 's/^(Acked|Reviewed|Reported|Tested|Suggested)-by: //p' "$1"