[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 10 Oct 2017 13:04:20 +0200
From: Greg KH <greg@...ah.com>
To: Mario Limonciello <mario.limonciello@...l.com>
Cc: dvhart@...radead.org, Andy Shevchenko <andy.shevchenko@...il.com>,
LKML <linux-kernel@...r.kernel.org>,
platform-driver-x86@...r.kernel.org,
Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
pali.rohar@...il.com, rjw@...ysocki.net, mjg59@...gle.com,
hch@....de
Subject: Re: [PATCH v6 13/14] platform/x86: wmi: create character devices
when requested by drivers
On Mon, Oct 09, 2017 at 05:51:51PM -0500, Mario Limonciello wrote:
> +static long wmi_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> +{
> + struct wmi_driver *wdriver = NULL;
> + struct wmi_block *wblock = NULL;
> + const char *driver_name;
> + struct list_head *p;
> + int ret;
> +
> + if (_IOC_TYPE(cmd) != WMI_IOC)
> + return -ENOTTY;
> +
> + driver_name = filp->f_path.dentry->d_iname;
> +
> + list_for_each(p, &wmi_block_list) {
No locking while walking the list, you are brave :(
Powered by blists - more mailing lists